Open
Conversation
egil
reviewed
Dec 9, 2025
Member
egil
left a comment
egil
left a comment
There was a problem hiding this comment.
At a glance, this looks good. I a wondering if the new extension types can be leverage here to get extension properties instead of extension methods only.
Collaborator
Author
|
Good thinking - but should we move this to v3 and align with FindByLabel? Otherwise we break our API style. |
Member
Good point. If this aligns with FindByLabel, then lets stay the course. |
Member
|
@scottsauber would love your take on this as well, if you have a little time to spare. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
FindByRoleandFindAllByRoleto bunit.web.query.